Skip to content

[ENH] test on oldest and latest matlab#150

Open
Remi-Gau wants to merge 1 commit intomainfrom
Remi-Gau-patch-1
Open

[ENH] test on oldest and latest matlab#150
Remi-Gau wants to merge 1 commit intomainfrom
Remi-Gau-patch-1

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 27, 2026 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Update MATLAB CI test matrix to cover the oldest supported and latest available versions across all operating systems.

CI:

  • Run MATLAB tests on ubuntu-latest, macos-latest, and windows-latest only.
  • Adjust MATLAB version matrix to test R2021a and the new latest R2025b, removing intermediate and OS-specific combinations.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 27, 2026 •
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the MATLAB GitHub Actions test matrix to cover the oldest supported (R2021a) and latest (R2025b) MATLAB versions across current OS images, simplifying macOS entries.

File-Level Changes

Change Details Files
Adjust the GitHub Actions MATLAB test matrix to use current OS labels and test the oldest and newest MATLAB releases.
  • Replace explicit OS list including macos-13 and a special macos-14 include with a simplified os matrix using ubuntu-latest, macos-latest, and windows-latest
  • Update MATLAB version matrix from R2021a and R2023b (plus a macOS-specific include) to R2021a and R2025b only, removing the macOS-specific override
 .github/workflows/run_tests_matlab.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 27, 2026
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • By switching from explicit macos-13/macos-14 to macos-latest, you lose control over the exact macOS versions being tested; if OS-specific behavior matters, consider keeping at least one pinned macOS version alongside macos-latest to avoid surprises when the runner image updates.
  • Hard-coding R2025b means this workflow will start failing as soon as it runs before that version is available; if the MATLAB action supports it, consider using a latest alias or updating the version string only once the release is actually supported.
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- By switching from explicit `macos-13`/`macos-14` to `macos-latest`, you lose control over the exact macOS versions being tested; if OS-specific behavior matters, consider keeping at least one pinned macOS version alongside `macos-latest` to avoid surprises when the runner image updates.
- Hard-coding `R2025b` means this workflow will start failing as soon as it runs before that version is available; if the MATLAB action supports it, consider using a `latest` alias or updating the version string only once the release is actually supported.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Remi-Gau